Skip to content

WIP: fix nesting of SingleBridgeOptimizer #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: fix nesting of SingleBridgeOptimizer #1322

wants to merge 1 commit into from

Conversation

odow
Copy link
Member

@odow odow commented May 7, 2021

Closes #1185

@blegat I think I need you to look at this.

@odow odow added Type: Bug Submodule: Bridges About the Bridges submodule labels May 7, 2021
@odow odow added this to the v0.10 milestone May 7, 2021
@odow odow requested a review from blegat May 7, 2021 03:43
@blegat
Copy link
Member

blegat commented May 7, 2021

If a LazyBridgeOptimizer has an inner SingleBridgeOptimizer then there will be this issue too. So this will be needed in LazyBridgeOptimizer as well.
However, I'm a bit afraid of performance implications of this. Maybe we can say that stacking Variable.SingleBridgeOptimizer is allowed but as the inner model of a LazyBridgeOptimizer. The performance of SingleBridgeOptimizer is less critical as it is mostly used for testing.

@blegat blegat mentioned this pull request May 9, 2021
Closed
@odow
Copy link
Member Author

odow commented May 11, 2021

Maybe we just say that chaining bridges isn't supported for now. Fixing this and checking it works in every case seems a much bigger task.

@odow
Copy link
Member Author

odow commented May 17, 2021

Closing because we need to think about this a bit more.

@odow odow closed this May 17, 2021
@odow odow deleted the od/bridges branch May 17, 2021 00:06
@blegat blegat mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat Awaiting requested review from blegat

Assignees
No one assigned
Labels
Submodule: Bridges About the Bridges submodule Type: Bug
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Chaining bridges doesn't work
2 participants
@odow @blegat