Refactor allocate-load API #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
May 12, 2021
| * [`Utilities.allocate_variables`](@ref) | ||
| * [`Utilities.allocate_constrained_variable`](@ref) | ||
| * [`Utilities.allocate_constrained_variables`](@ref) | ||
| * [`Utilities.allocate`](@ref) |
There was a problem hiding this comment.
Should this be renamed allocate_attribute?
| /`allocate`/`load_variables`/`load_constraint`/`load`. | ||
| That is, the allocate-load interface need to be used to copy an model to `model`. | ||
| """ | ||
| needs_allocate_load(::MOI.ModelLike) = false |
There was a problem hiding this comment.
I can't find this used anywhere. Is it safe to remove @blegat?
There was a problem hiding this comment.
Yes, there is a todo to remove it
|
Merging. I'll leave the changes for follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently just a moving of the allocate-load functions + some documentation. I'll comment in-line about possible changes.