Skip to content

Remove is_empty assertion in CachingOptimizer #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2021
Merged

Remove is_empty assertion in CachingOptimizer #1361

merged 2 commits into from
May 23, 2021

Conversation

odow
Copy link
Member

@odow odow commented May 21, 2021

There is no reason that the model_cache field has to be empty when creating a CachingOptimizer. (And it isn't checked in the other method.)

This is also needed for an upcoming PR to JuMP.

@odow odow added the Submodule: Utilities About the Utilities submodule label May 21, 2021
blegat
blegat approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@blegat blegat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This @assert made sense before #1254 as we were setting the mode to ATTACHED_OPTIMIZER but not anymore.

@odow odow merged commit ba74506 into master May 23, 2021
@odow odow deleted the odow-patch-1 branch May 23, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
Submodule: Utilities About the Utilities submodule
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat