Skip to content

Fix pass_nonvariable_constraints with bridged variables bis #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2021
Merged

Fix pass_nonvariable_constraints with bridged variables bis #1367

merged 1 commit into from
May 23, 2021

Conversation

blegat
Copy link
Member

@blegat blegat commented May 23, 2021

Forgot the return in #1354 so things were copied twice 🤦

@blegat blegat mentioned this pull request May 23, 2021
Closed
@odow
Copy link
Member

odow commented May 23, 2021

Yeah I don't fully understand the role of pass_nonvariable_constraints. Once the changes to matrixofconstraints are done, I'm going to go through and we what we can do.

@blegat
Copy link
Member Author

blegat commented May 23, 2021

Meanwhile, any objection to merge this ?

@odow
Copy link
Member

odow commented May 23, 2021

Nope. You're good to merge.

@blegat blegat merged commit 5bbe5ef into master May 23, 2021
@blegat blegat deleted the bl/pass_bridged_var_bis branch May 23, 2021 23:55
blegat added a commit that referenced this pull request May 23, 2021
@blegat
Fix pass_nonvariable_constraints with bridged variables bis (#1367)
f559840
@blegat blegat added this to the v0.9.22 milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 0.9 Submodule: Bridges About the Bridges submodule Type: Bug
Milestone
v0.9.22
Development

Successfully merging this pull request may close these issues.
2 participants
@blegat @odow