Fix getting constraint by name with MatrixOfConstraints #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero index is used to determine whether there are duplicate names:
MathOptInterface.jl/src/Utilities/model.jl
Line 243 in 65924e3
This was clashing with the fact that
MatrixOfConstraintswas returning zero indices. It turns out we don't really don't zero indices. In fact with this PR,ci.valuecorresponds to the row in the scalar case which is nice (and to the first row in the vector case). Before, it corresponded to the offset but it was zero for the first constraint.