Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented Jul 14, 2021

This is breaking for a user relying on the fact that SingleBridgeOptimizer was creating the constraint to the same model recursively.
It would have been used in a non-stackoverflow situation in case a bridge would create a constraint of the same time as the constraint being transformed twice and then not. I would guess no user was doing that but we never know.

Closes #1015

@odow
Copy link
Member

odow commented Jul 14, 2021

Potentially split the documentation updates and StackOverflow into two PRs?

@blegat
Copy link
Member Author

blegat commented Jul 14, 2021

Yes, I moved it to #1465, I will also create a separate PR for the Variable.SetMap as it will be useful for creating the variable identity bridges used for testing

@blegat blegat mentioned this pull request Jul 15, 2021
@blegat blegat force-pushed the bl/recursive_model branch from e883f56 to 92535be Compare July 16, 2021 03:45
@blegat blegat force-pushed the bl/recursive_model branch 2 times, most recently from 324b60b to 9fd2d91 Compare July 19, 2021 03:02
@blegat blegat marked this pull request as ready for review July 19, 2021 03:02
@blegat blegat force-pushed the bl/recursive_model branch 2 times, most recently from 663b975 to 802466f Compare July 20, 2021 21:40
@blegat blegat force-pushed the bl/recursive_model branch from 802466f to 0071102 Compare July 28, 2021 17:37
@blegat blegat merged commit 6dd3fc9 into master Aug 5, 2021
@blegat blegat deleted the bl/recursive_model branch August 5, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Bridged model for bridge optimizer
2 participants