Refactor box.jl #1468
Merged
Refactor box.jl #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it's a bit sketchy. The issue is that it's quite performance critical for MOIU.Model as we built this data-structure so to fix the performance regression from JuMP v0.18 to v0.19 with SingleVariable constraint |
|
I had a WIP that's coming along nicely. Just finishing up the tests. |
Closed
blegat
reviewed
Jul 15, 2021
blegat
reviewed
Jul 16, 2021
blegat
reviewed
Jul 19, 2021
blegat
reviewed
Jul 19, 2021
blegat
approved these changes
Jul 21, 2021
|
I like how simpler AbstractModel is |
|
Yeah, less state to carry around, easier to test, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started off by adding some tests to
box.jl, but I got confused. There's a muddle betweenbox.jlandmodel.jl, and who owns what and does what isn't clear. Making this commit now, and then I'm going to try and encapsulate all of the mask stuff into box.jl.Part of #1457