Add naming conventions. #1476
Merged
Add naming conventions. #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Jul 18, 2021
|
Thanks for having a look :)! |
odow
added
Status: Needs review
Type: Documentation
|
It looks like the discussion is in #1459, so I responded there. |
odow
reviewed
Jul 22, 2021
| * The name of the set is singular, instead of plural: prefer `Integer` to | ||
| `Integers`. | ||
| * The sets are named with nouns instead of verbs. Usual sets in mixed-integer | ||
| and convex programming only have such names. |
There was a problem hiding this comment.
What about Complements? I think we should just remove this one.
There was a problem hiding this comment.
Having a similar rule would really help with CP sets. Plus, I'm not sure that Complements is a good name in this case (#1459 (comment)): typically, complements is used as an infix operator in modelling languages, but MOI doesn't have "infix sets".
odow
reviewed
Jul 27, 2021
blegat
approved these changes
Jul 29, 2021
|
Merging these for now. We can always refine later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1459.