Fix isapprox for empty terms #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In a separate PR, these should all be moved to MOI.Utilities and made private. |
odow
added a commit
that referenced
this pull request
Jul 22, 2021
Currently needs test_broken due to the isapprox issue #1484
odow
added a commit
that referenced
this pull request
Jul 22, 2021
Currently needs test_broken due to the isapprox issue #1484
Yes, we want to be allow to break that. Making them private and not moving them in Utilities might be enough though. |
odow
added a commit
that referenced
this pull request
Jul 27, 2021
Currently needs test_broken due to the isapprox issue #1484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1483
Closes #1395