Skip to content

[breaking] remove isapprox for SOS sets #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2021
Merged

[breaking] remove isapprox for SOS sets #1492

merged 1 commit into from
Jul 26, 2021

Conversation

odow
Copy link
Member

@odow odow commented Jul 26, 2021

This was added in #711 because quote

[it] was defined in Test for no apparent reason

Seems like we can safely remove. It isn't hit by code coverage, and we don't offer isapprox for other sets.

@odow odow added the breaking label Jul 26, 2021
blegat
blegat approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, distance between sets is not well defined, distance from points to sets is being investigated in MathOptSetDistances and we don't yet want to have any interfaces for distances between sets

@odow odow merged commit 9ceb2de into master Jul 26, 2021
@odow odow deleted the od/rm_isapprox_sos branch July 26, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
breaking
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat