Skip to content

[breaking] re-order fields of QuadraticFunction #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2021
Merged

[breaking] re-order fields of QuadraticFunction #1499

merged 5 commits into from
Aug 3, 2021

Conversation

odow
Copy link
Member

@odow odow commented Jul 27, 2021

Closes #1406

@blegat pros and cons of merging this?

@odow odow added the breaking label Jul 27, 2021
@odow odow added this to the v0.10 milestone Jul 27, 2021
blegat
blegat approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could still consider having an affine function as a subfield of the quadratic but merging this won't prevent that so I don't see any cons.

@odow odow closed this Jul 28, 2021
@odow odow reopened this Jul 28, 2021
@odow odow merged commit 6afabbe into master Aug 3, 2021
@odow odow deleted the od/quadratic branch August 3, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
breaking
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Reorder fields of ScalarQuadraticFunction
2 participants
@odow @blegat