Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Aug 23, 2021

I was trying to address this TODO:

# Initially, (t, x) is of dimension d so x is dimension (d-1)
# TODO the sentence below is a little confusing, the n isn't used anywhere
# We create n new variables so that there are 2^l = d-1+n variables x_i
# We then need to create 2^l-1 new variables (1+2+...+2^{l-1})
# So the total number of variables is d+2^l-1

and I got very confused with the GeoMean implementation.

I started with some renaming, but then I gave up. It could use some much better documentation.

@odow odow requested a review from blegat August 23, 2021 02:34
@odow odow added the Submodule: Bridges About the Bridges submodule label Aug 23, 2021
@odow
Copy link
Member Author

odow commented Aug 23, 2021

@blegat do you have the pdf of the book? (Or want to expand the documentation?)

@odow odow merged commit d816122 into master Aug 23, 2021
@odow odow deleted the od/geomean branch August 23, 2021 23:11
@odow
Copy link
Member Author

odow commented Aug 23, 2021

Merging this for now. I'll come back with more documentation.

@odow odow mentioned this pull request Aug 23, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Submodule: Bridges About the Bridges submodule

Development

Successfully merging this pull request may close these issues.

2 participants