Document interface expected by subtypes #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
added
the
Type: Documentation
dourouc05
reviewed
Aug 27, 2021
dourouc05
reviewed
Aug 27, 2021
blegat
reviewed
Aug 27, 2021
blegat
reviewed
Aug 28, 2021
blegat
reviewed
Aug 31, 2021
blegat
reviewed
Aug 31, 2021
blegat
reviewed
Aug 31, 2021
blegat
reviewed
Aug 31, 2021
blegat
reviewed
Aug 31, 2021
odow
commented
Sep 2, 2021
blegat
reviewed
Sep 3, 2021
Co-authored-by: Benoît Legat <benoit.legat@gmail.com>
blegat
approved these changes
Sep 4, 2021
mlubin
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have never explicitly documented which attributes we expect to be implemented. To date it has been "whatever is needed to pass the tests."