Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Sep 3, 2021

No description provided.

@odow
Copy link
Member Author

odow commented Sep 3, 2021

@blegat this is broken because of

# Even if it is not bridged, it may have been force-bridged because one of
# the variable in the function was bridged.
if is_bridged(b, F, S) ||
(variable_function && supports_constraint_bridges(b))
value = operate_constraint_bridges!(value)
end

What's the || part doing here? Because variable_function && supports_constraint_bridges(b) only means that one of the inner variables might be bridged, not that they actually are. Ideas of how to fix?

@blegat
Copy link
Member

blegat commented Sep 5, 2021

What's the || part doing here? Because variable_function && supports_constraint_bridges(b) only means that one of the inner variables might be bridged, not that they actually are. Ideas of how to fix?

The issue was that we have to use recursive_model. This would have failed as well e.g. for a chordal bridge that bridges VAF-in-PSD -> VAF-in-PSD

@blegat blegat added this to the v0.10 milestone Sep 5, 2021
@odow odow merged commit 67a89d1 into master Sep 5, 2021
@odow odow deleted the od/slack branch September 5, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Submodule: Bridges About the Bridges submodule

Development

Successfully merging this pull request may close these issues.

2 participants