VariablePrimal: document undefined behaviour #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Sep 9, 2021
Present on all other attributes, save this one.
|
I added the comment (with the required adaptations, as far as I can see) for the other mentioned attributes. |
blegat
requested changes
Sep 10, 2021
There was a problem hiding this comment.
There is two cases here:
result_index>MOI.get(model, MOI.ResultCount()). In that case,ResultIndexBoundsErrorshould be thrown.result_index<=MOI.get(model, MOI.ResultCount())but only one of the dual and primal are available. In that case, it is undefined indeed.
With the current wording, it is confusing and not clear you are only talking about case 2)
|
@blegat I reformulated for |
blegat
reviewed
Sep 10, 2021
blegat
approved these changes
Sep 11, 2021
|
I have adapted the new paragraph for the other attributes. |
odow
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1600.
If you are OK with the wording, the same patch could be applied to
ConstraintDual,ConstraintBasisStatus,ObjectiveValue,DualObjectiveValue,VariableBasisStatus,ConstraintPrimal.