Skip to content

[Utilities] throw UnsupportedAttribute in pass_attributes #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

[Utilities] throw UnsupportedAttribute in pass_attributes #1613

merged 1 commit into from
Sep 15, 2021

Conversation

odow
Copy link
Member

@odow odow commented Sep 15, 2021

We should put a proper supports check here and throw the right error so down-stream users don't have to duplicate work.

Another idea from jump-dev/SCS.jl#219

@odow odow added the Submodule: Utilities About the Utilities submodule label Sep 15, 2021
@odow odow merged commit ab9d262 into master Sep 15, 2021
@odow odow deleted the od/pass_attribute branch September 15, 2021 06:18
@blegat
Copy link
Member

blegat commented Sep 15, 2021 •
edited
Loading

This shouldn't be needed, the fallback of MOI.set is already throwing the error.

@blegat blegat mentioned this pull request Sep 15, 2021
Closed
@blegat blegat mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Submodule: Utilities About the Utilities submodule
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat