Remove source of common test failure in LowerBoundAlreadySet #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will decrease coverage for some solvers, but there is a serious bug in the bridging system that requires a much deeper fix. This PR removes the common source of failure and adds a broken test to remind us to fix it in future.
blegat
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered a few ways of fixing #1431 (e.g., adding an Interval constraint so the variable would have a bound), but couldn't find anything satisfactory. The bridges need something like #1097, but that's a much greater fix.
This stops people running into the common source of failure, and it includes a broken test for us to fix in the future.
Closes #1431. I've opened #1665 to track the broader issue.