Fix PowerCone in MatrixOfConstraints #1722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
odow
changed the title
matbesancon
reviewed
Jan 24, 2022
|
SCS is passing tests with this PR, so I think we're good to go. |
matbesancon
approved these changes
Jan 25, 2022
|
@blegat bump |
blegat
approved these changes
Jan 31, 2022
blegat
reviewed
Jan 31, 2022
| return | ||
| end | ||
|
|
||
| load_constants(::Vector, ::Any, ::MOI.AbstractVectorSet) = nothing |
There was a problem hiding this comment.
It would probably be safer to be opt-in rather than opt-out here.
There was a problem hiding this comment.
That's breaking. And it's a bit of a pain to have to enumerate everything. Really, the failing tests in SCS should have picked this up earlier. But I obviously excluded them during development and didn't revisit them :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1721
To be used by jump-dev/SCS.jl#244