Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Feb 8, 2022

Damn. There are some pretty complicated ones here. I'll comment inline. GitHub action still to come because there are a few errors.

@odow odow changed the title Add Aqua.jl as a CI job and fix errors DNMY: Add Aqua.jl as a CI job and fix errors Feb 9, 2022
@odow
Copy link
Member Author

odow commented Feb 9, 2022

This PR touches a few different concepts, so I'll split it up into different PRs.

@odow
Copy link
Member Author

odow commented Feb 9, 2022

Okay. Once all the linked PRs are merged, I'll rebase this to add the GitHub action.

@odow odow force-pushed the od/aqua branch 2 times, most recently from c2c9336 to 3c2d503 Compare February 9, 2022 04:08
Add action and use inner constructors

Update aqua.yml
@odow odow changed the title DNMY: Add Aqua.jl as a CI job and fix errors Add Aqua.jl as a CI job and fix remaining errors Feb 10, 2022
@odow odow merged commit 259db93 into master Feb 11, 2022
@odow odow deleted the od/aqua branch February 11, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants