Add UniversalFallback utility to throw unsupported attributes and constraints #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@odow Good to merge ? |
|
Yes. I just wanted to release v1.0.2 first. This will go out as v1.1.0 since we're adding new features. |
Right, we need to follow semantic versioning now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be needed here:
https://github.com/jump-dev/Clp.jl/blob/6a6ebbf637f8933718645137e343bb969e1578e0/src/MOI_wrapper/MOI_wrapper.jl#L334-L339
Currently, the unsupported parts will just be ignored.
This is a blocker for Clp.jl and ECOS.jl releases. Using it allows to fix the last remaining failing tests in jump-dev/Clp.jl#130