Skip to content

Use tolerance to compare value of blank objective in test #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2022
Merged

Use tolerance to compare value of blank objective in test #1769

merged 1 commit into from
Mar 2, 2022

Conversation

blegat
Copy link
Member

@blegat blegat commented Mar 2, 2022 •
edited
Loading

With SDPA:

test_objective_ObjectiveFunction_blank: Test Failed at /home/runner/.julia/packages/MathOptInterface/FHFUH/src/Test/test_objective.jl:195
  Expression: MOI.get(model, MOI.ObjectiveValue()) == T(0)
   Evaluated: 1.3932339049530345e-8 == 0.0

See https://github.com/jump-dev/SDPA.jl/runs/5383637798?check_suite_focus=true#step:6:616

@odow
Copy link
Member

odow commented Mar 2, 2022

Why would it do this? 😢

@odow odow merged commit 53596c6 into master Mar 2, 2022
@odow odow deleted the bl/tol_blank branch March 2, 2022 03:06
@odow
Copy link
Member

odow commented Mar 2, 2022

Merging because this is correct. But I'd really like to know why SDPA would return a non-zero objective for min 0x!

@blegat
Copy link
Member Author

blegat commented Mar 2, 2022

No idea, I was surprised as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blegat @odow