Skip to content

Add vector fallback for get/set! #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2018
Merged

Add vector fallback for get/set! #216

merged 1 commit into from
Feb 11, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Feb 10, 2018 •
edited
Loading

Closes #212
We need to decide whether we want to split it for variable and constraints, the issue if we split is that we do not allow get(::SomeInstance, ::AnyProperty, ::Vector) as explained in the comment, is it a big issue ?

@blegat blegat merged commit 20b2ecf into master Feb 11, 2018
@mlubin mlubin mentioned this pull request Feb 12, 2018
Open
@blegat blegat deleted the bl/vectorfallback branch April 21, 2018 08:23
odow added a commit that referenced this pull request Jun 10, 2019
@odow
Fix tests from Gurobi #216
087203d
mlubin pushed a commit that referenced this pull request Jun 14, 2019
@odow @mlubin
Fix tests from Gurobi #216 (#763)
52988f7 
* Fix tests from Gurobi #216

* Skip bridging constraints that are supported

* Revert "Skip bridging constraints that are supported"

This reverts commit 6f2fa82.

* Fix missing specialization

* Add MOI.empty! to modellike tests

* Add more MOI.empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubin mlubin mlubin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegat @mlubin