Last big renaming #217
Merged
Last big renaming #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Feb 11, 2018
|
|
||
| A variable can be deleted from an instance with [`delete!(::AbstractInstance, ::VariableIndex)`](@ref MathOptInterface.delete!(::MathOptInterface.AbstractInstance, ::MathOptInterface.Index)), if this functionality is supported. | ||
| A variable can be deleted from a model with [`delete!(::ModelLike, ::VariableIndex)`](@ref MathOptInterface.delete!(::MathOptInterface.ModelLike, ::MathOptInterface.Index)), if this functionality is supported. | ||
|
|
docs/src/apimanual.md
Outdated
|
|
||
|
|
||
| Conic duality is the starting point for MOI's duality conventions. When all functions are affine (or coordinate projections), and all constraint sets are closed convex cone, the instance may be called a conic optimization problem. | ||
| Conic duality is the starting point for MOI's duality conventions. When all functions are affine (or coordinate projections), and all constraint sets are closed convex cone, the model may be called a conic optimization problem. |
|
Shouldn't |
blegat
reviewed
Feb 11, 2018
| An **Instance** ([`AbstractInstance`](@ref MathOptInterface.AbstractInstance)) is a representation of a concrete instance of an optimization problem, i.e., with all data specified. Instances are either **standalone instances** or **solver instances**: | ||
| The most significant part of MOI is the definition of the **model API** that is | ||
| used to specify an instance of an optimization problem (e.g., by adding | ||
| variables and constraints). Objects that implement the model API should inherit |
There was a problem hiding this comment.
"Objects that implement the model API" -> "Objects that implement parts of the model API" ? Or we consider that if an object does not implement something and say can... -> false then it is a complete implementation ?
There was a problem hiding this comment.
We should definitely add a discussion in the documentation of the different ways to implement the model API, but for the purposes of this sentence, I consider copy-only a valid implementation of the model API.
There was a problem hiding this comment.
Yes, I think that if can... return false, it should be considered a valid implementation
blegat
approved these changes
Feb 11, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractInstance->ModelLikeAbstractStandaloneInstance-> goneAbstractSolverInstance->AbstractOptimizerAbstractInstanceAttribute->AbstractModelAttributeAbstractSolverParameter->AbstractOptimizerAttributeUpdated the discussion in the manual, let me know if it reads well. If there's consensus on this renaming, I'll queue up PRs on the downstream packages and merge all at once.
Closes #203