Fix various JET errors #2276
Merged
Fix various JET errors #2276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Sep 20, 2023
| MOI.VectorQuadraticFunction{T}, | ||
| MOI.VectorNonlinearFunction, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Hmm. This breaks JuMP:
https://github.com/jump-dev/JuMP.jl/blob/1ee5faee4335386435e3211b8758fba13799234e/test/test_objective.jl#L168-L180
I'm not sure whether we intended this:
julia> model = GenericModel{Float32}();
julia> @variable(model, x)
x
julia> @objective(model, Min, 2 * x + 1)
2 x + 1
julia> f = objective_function(model, GenericAffExpr{Float64,VariableRef})
2 x + 1
julia> typeof(f)
GenericAffExpr{Float64, GenericVariableRef{Float32}}
julia> g = objective_function(model)
2 x + 1
julia> typeof(g)
GenericAffExpr{Float32, GenericVariableRef{Float32}}There was a problem hiding this comment.
There was a problem hiding this comment.
No I think we meant to use T instead of Float64 in the test
There was a problem hiding this comment.
Yeah. I guess we just leave this as-is for now though.
blegat
reviewed
Sep 20, 2023
| return x | ||
| end | ||
|
|
||
| function MOI.add_variables(model::AbstractModel, n::Integer) |
There was a problem hiding this comment.
It's the same as the default fallback
There was a problem hiding this comment.
Ah yes, it's in Utilities/model.jl. We indeed used to not have that default fallback
blegat
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2268
Now down to
═════ 70 possible errors found ═════https://github.com/jump-dev/MathOptInterface.jl/actions/runs/6242312138