Fix JET errors in bridge_optimizer.jl #2277
Conversation
This one deserved a separate commit because the changes are a little subtle. The various Bridge submodules define EmptyMap as a fallback for when an AbstractBridgeOptimizer doesn't have an associated set of arcs (like a Variable.SingleBridgeOptimizer). But this makes all calls of .bridges(b) type unstable. And sometimes we really do want either, but sometimes (like the ones annnotated here), we want only the explicit Map. For MOI v2, we could consider refactoring this code to remove EmptyMap in favor of a more explicit fallback like nothing.
I think it'd just make it clearer what's actually going on. We don't really want to use |
IIRC, it was helpful because it implements the |
Only in some places though. It doesn't implement any of these call sites which need annotations (because they wouldn't get called for a |
|
It's possible, I'd have to take another look, it's been a long time |
2 participants
This one deserved a separate commit because the changes are a little subtle.
The various Bridge submodules define EmptyMap as a fallback for when an AbstractBridgeOptimizer doesn't have an associated set of arcs (like a Variable.SingleBridgeOptimizer). But this makes all calls of .bridges(b) type unstable. And sometimes we really do want either, but sometimes (like the ones annnotated here), we want only the explicit Map.
For MOI v2, we could consider refactoring this code to remove EmptyMap in favor of a more explicit fallback like nothing.
This PR brings us down to
═════ 42 possible errors found ═════