[Nonlinear] make _(Function|Subexpression)Storage immutable #2621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2620 that brings things down to
I can't find the reason I made these mutable.See the latest commit. I guess I wanted to make minimal changes to the existing code.They didn't exist in the original JuMP code:
https://github.com/jump-dev/JuMP.jl/blob/0a6b1e426425e69234f073079c3ebe6301a43f25/src/_Derivatives/forward.jl#L30-L31
so when I created them in #1803 I guess I had a reason for making them mutable at some point that didn't survive the final factoring.