Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented May 1, 2019

This removes the need for the @bridge macro but now bridges need to implement getters from ConstraintFunction and ConstraintSet if they want to getter to work for the bridge optimizer.

Closes #713

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #722 into master will increase coverage by 0.28%.
The diff coverage is 95.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   93.83%   94.11%   +0.28%     
==========================================
  Files          54       54              
  Lines        5677     5746      +69     
==========================================
+ Hits         5327     5408      +81     
+ Misses        350      338      -12
Impacted Files Coverage Δ
src/Bridges/scalarizebridge.jl 53.12% <ø> (ø) ⬆️
src/Bridges/intervalbridge.jl 86.84% <100%> (+6.28%) ⬆️
src/Bridges/slackbridge.jl 95.16% <100%> (+0.33%) ⬆️
src/Bridges/functionize_bridge.jl 97.5% <100%> (+7.84%) ⬆️
src/Bridges/quadtosocbridge.jl 97.26% <100%> (+3.81%) ⬆️
src/Utilities/functions.jl 92% <100%> (+0.13%) ⬆️
src/Bridges/lazybridgeoptimizer.jl 97.43% <100%> (ø) ⬆️
src/Test/contlinear.jl 100% <100%> (ø) ⬆️
src/Utilities/universalfallback.jl 98.13% <100%> (-0.04%) ⬇️
src/Bridges/Bridges.jl 100% <100%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88656c6...4832579. Read the comment docs.

@blegat blegat added this to the v0.9 milestone May 2, 2019
@blegat blegat force-pushed the bl/get_constraint branch from 9f41124 to 1f1bd55 Compare May 3, 2019 09:30
@blegat blegat added the breaking label May 3, 2019
@blegat blegat merged commit 681f4c3 into master May 3, 2019
@odow odow deleted the bl/get_constraint branch June 15, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Require bridges to implement MOI.get for ConstraintFunction and ConstraintSet
2 participants