Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented May 10, 2019

Other matrix sets are defined in SumOfSquares:
https://github.com/JuliaOpt/SumOfSquares.jl/blob/master/src/diagonally_dominant.jl
https://github.com/JuliaOpt/SumOfSquares.jl/blob/master/src/psd2x2.jl
https://github.com/JuliaOpt/SumOfSquares.jl/blob/master/src/empty_bridge.jl
and having abstract sets would allow these sets to benefit from what is implemented for the PSDSquare and PSDTriangle sets such as the SquareBridge.

@blegat blegat added this to the v0.9 milestone May 10, 2019
@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #731 into master will decrease coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   94.21%   94.19%   -0.02%     
==========================================
  Files          54       54              
  Lines        5821     5825       +4     
==========================================
+ Hits         5484     5487       +3     
- Misses        337      338       +1
Impacted Files Coverage Δ
src/Bridges/square_bridge.jl 98.27% <100%> (ø)
src/Utilities/results.jl 90.26% <100%> (ø) ⬆️
src/Bridges/Bridges.jl 100% <100%> (ø) ⬆️
src/sets.jl 92.72% <85.71%> (-1.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae1ced...538b18d. Read the comment docs.

@blegat blegat mentioned this pull request May 10, 2019
@blegat blegat merged commit f3746b6 into master May 12, 2019
@odow odow deleted the bl/matrix_sets branch June 15, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants