Skip to content

Add CachingOptimizer in doc #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 11, 2019
Merged

Add CachingOptimizer in doc #777

merged 8 commits into from
Jul 11, 2019

Conversation

frapac
Copy link
Contributor

@frapac frapac commented Jun 23, 2019

Solve #770

Note that:

  • this is a first attempt. If I miss anything, I welcome any feedback.
  • I am not sure of the position of the CachingOptimizer paragraph in the page apireference.md: shall CachingOptimizer precede Allocate-Load API?

@codecov-io
Copy link

codecov-io commented Jun 24, 2019 •
edited
Loading

Codecov Report

Merging #777 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files          59       59           
  Lines        6481     6481           
=======================================
  Hits         6109     6109           
  Misses        372      372
Impacted Files Coverage Δ
src/Benchmarks/Benchmarks.jl 98.71% <ø> (ø) ⬆️
src/Utilities/cachingoptimizer.jl 92.48% <ø> (ø) ⬆️
src/sets.jl 92.72% <0%> (ø) ⬆️
src/Utilities/model.jl 91.46% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719bc68...142f86d. Read the comment docs.

blegat
blegat reviewed Jun 24, 2019
View reviewed changes
blegat
blegat reviewed Jun 24, 2019
View reviewed changes
blegat
blegat reviewed Jun 24, 2019
View reviewed changes
blegat
blegat reviewed Jun 24, 2019
View reviewed changes
blegat
blegat reviewed Jun 24, 2019
View reviewed changes
blegat
blegat reviewed Jun 24, 2019
View reviewed changes
blegat
blegat reviewed Jul 1, 2019
View reviewed changes
blegat
blegat reviewed Jul 1, 2019
View reviewed changes
blegat
blegat reviewed Jul 1, 2019
View reviewed changes
blegat
blegat reviewed Jul 1, 2019
View reviewed changes
blegat
blegat reviewed Jul 1, 2019
View reviewed changes
blegat
blegat approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@frapac
Copy link
Contributor Author

frapac commented Jul 2, 2019

Thanks for your review!

@blegat blegat added this to the v0.9 milestone Jul 3, 2019
@blegat blegat added the Submodule: Utilities About the Utilities submodule label Jul 3, 2019
mlubin
mlubin reviewed Jul 5, 2019
View reviewed changes
Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor language comments.

@frapac
Copy link
Contributor Author

frapac commented Jul 8, 2019

Thanks for the comments!

@blegat blegat merged commit fb043fa into jump-dev:master Jul 11, 2019
@blegat blegat mentioned this pull request Jul 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubin mlubin mlubin left review comments

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
Submodule: Utilities About the Utilities submodule
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@frapac @codecov-io @blegat @mlubin