Fix broadcast for scalar sets #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
reviewed
Jul 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
=========================================
+ Coverage 94.1% 94.1% +<.01%
=========================================
Files 59 59
Lines 6671 6672 +1
=========================================
+ Hits 6278 6279 +1
Misses 393 393
Continue to review full report at Codecov.
|
mlubin
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining scalar sets as 0-dimensional for broadcast seems reasonable.
cc @tweisser