Skip to content

Dual sets #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 1, 2019
Merged

Dual sets #804

merged 19 commits into from
Aug 1, 2019

Conversation

guilhermebodin
Copy link
Contributor

@guilhermebodin guilhermebodin mentioned this pull request Jul 23, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jul 23, 2019 •
edited
Loading

Codecov Report

Merging #804 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #804      +/-   ##
=========================================
+ Coverage   94.09%   94.1%   +0.01%     
=========================================
  Files          59      59              
  Lines        6795    6808      +13     
=========================================
+ Hits         6394    6407      +13     
  Misses        401     401
Impacted Files Coverage Δ
src/sets.jl 91.66% <100%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c0e0fc...18595ff. Read the comment docs.

blegat
blegat reviewed Jul 23, 2019
View reviewed changes
blegat
blegat reviewed Jul 23, 2019
View reviewed changes
mlubin
mlubin reviewed Jul 24, 2019
View reviewed changes
mlubin
mlubin reviewed Jul 25, 2019
View reviewed changes
mlubin
mlubin reviewed Jul 25, 2019
View reviewed changes
mlubin
mlubin reviewed Jul 27, 2019
View reviewed changes
src/sets.jl Outdated
dual_set(s::AbstractSet)
Return the dual set of `s`, that is the dual cone of the set. This follows the
definition of `MathOptInterface` discussed in http://www.juliaopt.org/MathOptInterface.jl/stable/apimanual/#Advanced-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For version consistency, please reference this section using an internal link instead of a URL. See https://juliadocs.github.io/Documenter.jl/stable/man/syntax/#@ref-link-1. It might take a couple tries to work as I'm not sure of the exact syntax. You can double check that the link works by building the documentation locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mlubin mlubin merged commit 4a60494 into jump-dev:master Aug 1, 2019
@blegat
Copy link
Member

blegat commented Aug 1, 2019

@guilhermebodin Could you make a PR to update the NEWS.md ? (use [ci skip] in your commit to avoid unnecessary travis checks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blegat blegat blegat approved these changes

@mlubin mlubin mlubin left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guilhermebodin @codecov-io @blegat @mlubin