Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented Jul 31, 2019

Extracted from #759

@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #807 into master will decrease coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   94.21%   94.18%   -0.03%     
==========================================
  Files          59       60       +1     
  Lines        6892     6928      +36     
==========================================
+ Hits         6493     6525      +32     
- Misses        399      403       +4
Impacted Files Coverage Δ
src/Utilities/Utilities.jl 100% <ø> (ø) ⬆️
src/Utilities/lazy_iterators.jl 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01367a...8b30e6e. Read the comment docs.

Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have tests for these utilities, could you include them in this PR rather than a later one?

@blegat blegat merged commit a1778e9 into master Aug 1, 2019
@odow odow deleted the bl/array_utils branch August 29, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants