Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented Aug 1, 2019

  • Change coefficients for offdiag vs diag quadratic terms

This also fixes a few bugs in MOIU.operate with quadratic terms

Extracted from #759

@blegat blegat changed the title Bl/substitute Add substitute_variables Aug 1, 2019
@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #811 into master will decrease coverage by 1.79%.
The diff coverage is 92.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #811     +/-   ##
=========================================
- Coverage   94.12%   92.33%   -1.8%     
=========================================
  Files          61       65      +4     
  Lines        6914     7838    +924     
=========================================
+ Hits         6508     7237    +729     
- Misses        406      601    +195
Impacted Files Coverage Δ
src/sets.jl 91.26% <ø> (-0.4%) ⬇️
src/Utilities/functions.jl 95.11% <92.94%> (-0.23%) ⬇️
src/Utilities/sets.jl 25% <0%> (-75%) ⬇️
src/Bridges/Constraint/indicator.jl 95.23% <0%> (-4.77%) ⬇️
src/Bridges/Constraint/geomean.jl 97.33% <0%> (-2.67%) ⬇️
src/Bridges/Constraint/functionize.jl 92.53% <0%> (-2.47%) ⬇️
src/Bridges/Constraint/rsoc.jl 97.56% <0%> (-2.44%) ⬇️
src/Bridges/Constraint/quad_to_soc.jl 95.55% <0%> (-1.78%) ⬇️
src/Bridges/Constraint/soc_to_psd.jl 98.8% <0%> (-1.2%) ⬇️
src/Bridges/Constraint/square.jl 97.36% <0%> (-0.91%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead6f88...9f07bc8. Read the comment docs.

@blegat blegat merged commit d3106f4 into master Aug 4, 2019
@odow odow deleted the bl/substitute branch August 29, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants