Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented Aug 5, 2019

Extracted from #759

@blegat blegat force-pushed the bl/bridge_opt_with_var branch from 9cca68c to 831efd5 Compare August 5, 2019 22:39
Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any substantive comments, so merge when ready.

@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #816 into master will decrease coverage by 1.19%.
The diff coverage is 54.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #816     +/-   ##
=========================================
- Coverage   92.04%   90.84%   -1.2%     
=========================================
  Files          65       66      +1     
  Lines        7218     7431    +213     
=========================================
+ Hits         6644     6751    +107     
- Misses        574      680    +106
Impacted Files Coverage Δ
src/Bridges/Variable/Variable.jl 100% <ø> (ø) ⬆️
src/Bridges/Variable/single_bridge_optimizer.jl 0% <0%> (ø)
src/Bridges/Constraint/slack.jl 93.75% <100%> (+0.2%) ⬆️
src/Bridges/Constraint/single_bridge_optimizer.jl 44.44% <20%> (-15.56%) ⬇️
src/Bridges/bridge_optimizer.jl 62.21% <55.64%> (-31.46%) ⬇️
src/Bridges/lazy_bridge_optimizer.jl 65.16% <58.66%> (-32.27%) ⬇️
src/Bridges/Variable/bridge.jl 0% <0%> (ø) ⬆️
src/Utilities/mockoptimizer.jl 90.14% <0%> (+0.49%) ⬆️
src/Bridges/Constraint/quad_to_soc.jl 97.36% <0%> (+1.31%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3106f4...291c11b. Read the comment docs.

@blegat blegat merged commit 42cdc34 into master Aug 6, 2019
@odow odow deleted the bl/bridge_opt_with_var branch August 29, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants