Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented Aug 9, 2019

This improves the errors obtained when parsing an incorrect string.

@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #825 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
+ Coverage   93.49%   93.51%   +0.02%     
==========================================
  Files          70       71       +1     
  Lines        7610     7653      +43     
==========================================
+ Hits         7115     7157      +42     
- Misses        495      496       +1
Impacted Files Coverage Δ
src/Utilities/parser.jl 97.43% <100%> (+0.11%) ⬆️
src/Bridges/Variable/free.jl 87.87% <0%> (ø)
src/Bridges/bridge_optimizer.jl 90.67% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1db9f4...916964c. Read the comment docs.

Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was pretty lazy in writing the parser given that it's for internal use only.

@blegat blegat merged commit 2aee608 into master Aug 9, 2019
@odow odow deleted the bl/parser_error branch August 29, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants