Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Aug 13, 2019

Current tests weren't testing the edge-case where we rename variables/constraints.

ref jump-dev/Gurobi.jl#216, jump-dev/GLPK.jl#101

Also, it doesn't look like the modellike.jl tests are tested?

@codecov-io
Copy link

Codecov Report

Merging #833 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
+ Coverage   94.83%   94.85%   +0.02%     
==========================================
  Files          71       71              
  Lines        7643     7681      +38     
==========================================
+ Hits         7248     7286      +38     
  Misses        395      395
Impacted Files Coverage Δ
src/Test/modellike.jl 99.38% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb800e9...81b0758. Read the comment docs.

@odow
Copy link
Member Author

odow commented Aug 18, 2019

Bump. Barring objections, I'll merge this tomorrow.

@odow odow merged commit da6a952 into master Aug 19, 2019
@odow odow deleted the od/names branch August 19, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants