Skip to content

Conversation

guilhermebodin
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #839 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
+ Coverage   94.83%   94.95%   +0.11%     
==========================================
  Files          71       72       +1     
  Lines        7649     7910     +261     
==========================================
+ Hits         7254     7511     +257     
- Misses        395      399       +4
Impacted Files Coverage Δ
src/Test/contconic.jl 99.42% <100%> (-0.36%) ⬇️
src/Bridges/Constraint/Constraint.jl 100% <0%> (ø) ⬆️
src/Test/UnitTests/basic_constraint_tests.jl 98% <0%> (ø) ⬆️
src/Bridges/Constraint/soc_to_psd.jl 100% <0%> (ø) ⬆️
src/Bridges/Constraint/norm_to_lp.jl 100% <0%> (ø)
src/Utilities/functions.jl 94.63% <0%> (+0.04%) ⬆️
src/Test/modellike.jl 99.38% <0%> (+0.05%) ⬆️
src/sets.jl 94.73% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed068f...40c77fe. Read the comment docs.


@test MOI.get(model, MOI.TerminationStatus()) == MOI.INFEASIBLE
@test MOI.get(model, MOI.TerminationStatus()) in (MOI.INFEASIBLE,
MOI.INFEASIBLE_OR_UNBOUNDED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow Why do we need to support INFEASIBLE_OR_UNBOUNDED? We can set the following parameters so that Gurobi doesn't return this status:
https://www.gurobi.com/documentation/8.0/refman/infunbdinfo.html
https://www.gurobi.com/documentation/8.0/refman/dualreductions.html#parameter:DualReductions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooo. I didn't realize there was this parameter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated Gurobi to use the parameter, and reverted the change here.

@mlubin mlubin merged commit 2558aad into jump-dev:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants