Skip to content
This repository was archived by the owner on Sep 26, 2019. It is now read-only.
This repository was archived by the owner on Sep 26, 2019. It is now read-only.

undefined as part of a union type doesn't seem to transfer as being optional #72

@jumpinjackie

Description

@jumpinjackie

If a union type includes undefined, the type as a whole should be implied as being optional.

Take the layers property of the OverviewMap options:

https://github.com/openlayers/ol3/blob/v3.18.2/externs/olx.js#L1170

This is currently being emitted as:

layers: ol.layer.Layer[]|ol.Collection<ol.layer.Layer>

when it should've been emitted as

layers?: ol.layer.Layer[]|ol.Collection<ol.layer.Layer>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions