-
Notifications
You must be signed in to change notification settings - Fork 8
Remove jmpctl and go release action #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change removes the entire CLI tool functionality for managing "jumpstarter" resources. All related Go source files, Makefile targets, and the GitHub Actions workflow for releasing the CLI have been deleted or updated to exclude the CLI. The build and deployment process is now focused solely on the manager binary. Changes
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Makefile (1)
151-151: Add help description for thedeploy-exporterstarget
As written,deploy-exporters:lacks a##comment, so it won’t appear in the output ofmake help. Consider adding an inline description to improve discoverability..PHONY: deploy-exporters -deploy-exporters: +deploy-exporters: ## Prepare and deploy exporters without CLI dependency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/goreleaser.yaml(0 hunks)Makefile(2 hunks)cmd/jmpctl/main.go(0 hunks)internal/cmd/client.go(0 hunks)internal/cmd/exporter.go(0 hunks)internal/cmd/root.go(0 hunks)
💤 Files with no reviewable changes (5)
- cmd/jmpctl/main.go
- .github/workflows/goreleaser.yaml
- internal/cmd/root.go
- internal/cmd/client.go
- internal/cmd/exporter.go
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: tests
- GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
- GitHub Check: e2e-tests (ubuntu-24.04-arm)
- GitHub Check: e2e-tests (ubuntu-24.04)
- GitHub Check: lint-go
- GitHub Check: deploy-kind
🔇 Additional comments (1)
Makefile (1)
29-29: Simplifyalltarget to build only the manager binary
Thealltarget has been updated to depend solely onbuild, removing the now-defunctbin/jmpctldependency. This aligns with the PR’s objective to drop the CLI tool.
|
Successfully created backport PR for |
Summary by CodeRabbit