Skip to content

Conversation

@mangelajo
Copy link
Member

depends on #177

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch auto-detect-basedomain

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.


// Format the baseDomain as "namespace.apps.openShiftBaseDomain"
// This matches the Helm template behavior when .noNs is false
detectedBaseDomain := fmt.Sprintf("%s.apps.%s", namespace, openShiftBaseDomain)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using apps.<baseDomain> works for most OpenShift clusters, but since the domain can be customized by admins, it might be safer to read it from the cluster’s ingress configuration instead of using hardcoded value, wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that would make sense 👍 I need to check where that ingress configuration lives :)

Base automatically changed from autodetect-and-route-support to main October 30, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants