Skip to content

Commit 3ef97bf

Browse files
authored
Restructure ConsoleLauncher to avoid package cycles (#4926)
All of these packages are considered internal so no deprecation cycle is needed.
1 parent ad0ee62 commit 3ef97bf

File tree

54 files changed

+155
-104
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+155
-104
lines changed

junit-platform-console/src/main/java/org/junit/platform/console/ConsoleLauncher.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
import java.io.PrintWriter;
1717

1818
import org.apiguardian.api.API;
19-
import org.junit.platform.console.options.CommandFacade;
20-
import org.junit.platform.console.options.CommandResult;
21-
import org.junit.platform.console.tasks.ConsoleTestExecutor;
22-
import org.junit.platform.console.tasks.CustomClassLoaderCloseStrategy;
19+
import org.junit.platform.console.command.CommandFacade;
20+
import org.junit.platform.console.command.CommandResult;
21+
import org.junit.platform.console.command.ConsoleTestExecutor;
22+
import org.junit.platform.console.command.CustomClassLoaderCloseStrategy;
2323

2424
/**
2525
* The {@code ConsoleLauncher} is a stand-alone application for launching the
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.options;
11+
package org.junit.platform.console.command;
1212

1313
import java.io.PrintWriter;
1414
import java.util.concurrent.Callable;
1515

1616
import org.junit.platform.commons.PreconditionViolationException;
17+
import org.junit.platform.console.options.AnsiColorOptionMixin;
1718

1819
import picocli.CommandLine;
1920
import picocli.CommandLine.Mixin;
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.options;
11+
package org.junit.platform.console.command;
1212

1313
import static org.apiguardian.api.API.Status.INTERNAL;
1414

1515
import java.io.PrintWriter;
1616
import java.util.Optional;
1717

1818
import org.apiguardian.api.API;
19-
import org.junit.platform.console.tasks.ConsoleTestExecutor;
2019

2120
/**
2221
* Internal facade to run a CLI command that exists to hide implementation
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.options;
11+
package org.junit.platform.console.command;
1212

1313
import static org.apiguardian.api.API.Status.INTERNAL;
1414

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.tasks;
11+
package org.junit.platform.console.command;
1212

1313
import static java.util.Objects.requireNonNullElseGet;
1414
import static org.apiguardian.api.API.Status.INTERNAL;
15-
import static org.junit.platform.console.tasks.DiscoveryRequestCreator.toDiscoveryRequestBuilder;
15+
import static org.junit.platform.console.command.DiscoveryRequestCreator.toDiscoveryRequestBuilder;
1616
import static org.junit.platform.launcher.LauncherConstants.OUTPUT_DIR_PROPERTY_NAME;
1717

1818
import java.io.PrintStream;
@@ -32,7 +32,13 @@
3232
import org.junit.platform.console.options.Details;
3333
import org.junit.platform.console.options.TestConsoleOutputOptions;
3434
import org.junit.platform.console.options.TestDiscoveryOptions;
35-
import org.junit.platform.console.options.Theme;
35+
import org.junit.platform.console.output.ColorPalette;
36+
import org.junit.platform.console.output.DetailsPrintingListener;
37+
import org.junit.platform.console.output.FlatPrintingListener;
38+
import org.junit.platform.console.output.TestFeedPrintingListener;
39+
import org.junit.platform.console.output.Theme;
40+
import org.junit.platform.console.output.TreePrintingListener;
41+
import org.junit.platform.console.output.VerboseTreePrintingListener;
3642
import org.junit.platform.engine.CancellationToken;
3743
import org.junit.platform.launcher.Launcher;
3844
import org.junit.platform.launcher.LauncherDiscoveryRequest;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.tasks;
11+
package org.junit.platform.console.command;
1212

1313
import static org.apiguardian.api.API.Status.INTERNAL;
1414

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.tasks;
11+
package org.junit.platform.console.command;
1212

1313
import java.util.Optional;
1414
import java.util.function.Supplier;
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,14 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.options;
11+
package org.junit.platform.console.command;
1212

1313
import java.io.PrintWriter;
1414

15-
import org.junit.platform.console.tasks.ConsoleTestExecutor;
15+
import org.junit.platform.console.options.TestConsoleOutputOptions;
16+
import org.junit.platform.console.options.TestConsoleOutputOptionsMixin;
17+
import org.junit.platform.console.options.TestDiscoveryOptions;
18+
import org.junit.platform.console.options.TestDiscoveryOptionsMixin;
1619

1720
import picocli.CommandLine.Command;
1821
import picocli.CommandLine.Mixin;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.tasks;
11+
package org.junit.platform.console.command;
1212

1313
import static org.junit.platform.engine.discovery.ClassNameFilter.excludeClassNamePatterns;
1414
import static org.junit.platform.engine.discovery.ClassNameFilter.includeClassNamePatterns;
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,19 @@
88
* https://www.eclipse.org/legal/epl-v20.html
99
*/
1010

11-
package org.junit.platform.console.options;
11+
package org.junit.platform.console.command;
1212

13-
import static org.junit.platform.console.options.CommandResult.SUCCESS;
13+
import static org.junit.platform.console.command.CommandResult.SUCCESS;
1414

1515
import java.io.PrintWriter;
1616
import java.nio.file.Path;
1717
import java.util.Optional;
1818

1919
import org.jspecify.annotations.Nullable;
20-
import org.junit.platform.console.tasks.ConsoleTestExecutor;
20+
import org.junit.platform.console.options.TestConsoleOutputOptions;
21+
import org.junit.platform.console.options.TestConsoleOutputOptionsMixin;
22+
import org.junit.platform.console.options.TestDiscoveryOptions;
23+
import org.junit.platform.console.options.TestDiscoveryOptionsMixin;
2124
import org.junit.platform.launcher.listeners.TestExecutionSummary;
2225

2326
import picocli.CommandLine;

0 commit comments

Comments
 (0)