Add JRE.JAVA_25 #4181
Merged
Add JRE.JAVA_25 #4181
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `JRE.JAVA_25` constant and JDK 25 CI build Closes #4177
marcphilipp
requested changes
Dec 8, 2024
[skip ci] Co-authored-by: Marc Philipp <mail@marcphilipp.de>
marcphilipp
approved these changes
Dec 8, 2024
sormuras
commented
Dec 9, 2024
Member
Author
sormuras
left a comment
sormuras
left a comment
There was a problem hiding this comment.
Add backticks around type and constant names
documentation/src/docs/asciidoc/release-notes/release-notes-5.12.0-M1.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/release-notes/release-notes-5.11.4.adoc
Outdated
Show resolved
Hide resolved
[skip ci]
marcphilipp
requested changes
Dec 9, 2024
Member
marcphilipp
left a comment
marcphilipp
left a comment
There was a problem hiding this comment.
I don't think this should be included in the 5.12.0-M1 release notes since we're releasing 5.11.4 before 5.12.0-M1 so it's reasonable to assume everything from the former is contained in the latter.
Member
Author
|
Yeah, had a similar thought, but someone who reads only the 5.12(.0) notes should get a chance to see what's new compared to the 5.11(.0) notes, not? |
Member
|
I don't think we've usually done that. I'm okay with keeping it, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add
JRE.JAVA_25constant and JDK 25 CI buildCloses #4177
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations