Document that AnnotationSupport.isAnnotated() does not find repeatable annotations
#4243
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YongGoose
force-pushed
the
feature/4058
branch
from
38b67c9 to
c40c41a
Compare
YongGoose
force-pushed
the
feature/4058
branch
from
c40c41a to
af853ea
Compare
marcphilipp
requested changes
Jan 13, 2025
sbrannen
requested changes
Jan 13, 2025
Member
sbrannen
left a comment
sbrannen
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've requested a few minor changes.
junit-platform-commons/src/main/java/org/junit/platform/commons/support/AnnotationSupport.java
Outdated
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/support/AnnotationSupport.java
Outdated
Show resolved
Hide resolved
sbrannen
added
status: duplicate
theme: extensions
component: Jupiter
theme: documentation
component: Platform
and removed
status: duplicate
labels
Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
…s/support/AnnotationSupport.java Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
…s/support/AnnotationSupport.java Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
Issue: junit-team#4058
Contributor
Author
|
Thank you for your comments! |
marcphilipp
requested changes
Jan 15, 2025
Issue: junit-team#4058
YongGoose
force-pushed
the
feature/4058
branch
from
16ca479 to
bda5b1a
Compare
sbrannen
approved these changes
Jan 15, 2025
marcphilipp
approved these changes
Jan 16, 2025
Member
|
@YongGoose Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4058
Overview
AnnotationSupport.isAnnotated()variants to reflect this.AnnotationSupportto reflect this, if applicable.AnnotatedElementContext.isAnnotated()to reflect this.I hereby agree to the terms of the JUnit Contributor License Agreement.