Add socket support to OpenTestReportGeneratingListener #5096
+133
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
requested changes
Oct 27, 2025
...c/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListener.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListener.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListener.java
Outdated
Show resolved
Hide resolved
|
@marcphilipp thanks for your review and suggestions, I applied them now and tried to adapt the test as you proposed! |
- Add SOCKET_PROPERTY_NAME constant for junit.platform.reporting.open.xml.socket - Implement createDocumentWriter method to support both file and socket outputs - When socket property is set, connect to localhost:<port> and write XML to socket - Add comprehensive test for socket-based reporting - Update documentation to describe socket configuration parameter - Update release notes with new feature Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: Marc Philipp <mail@marcphilipp.de>
Co-authored-by: Marc Philipp <mail@marcphilipp.de>
Co-authored-by: Marc Philipp <mail@marcphilipp.de>
…/xml/OpenTestReportGeneratingListenerTests.java Co-authored-by: Marc Philipp <mail@marcphilipp.de>
…/xml/OpenTestReportGeneratingListenerTests.java Co-authored-by: Marc Philipp <mail@marcphilipp.de>
…/xml/OpenTestReportGeneratingListenerTests.java Co-authored-by: Marc Philipp <mail@marcphilipp.de>
…/xml/OpenTestReportGeneratingListenerTests.java Co-authored-by: Marc Philipp <mail@marcphilipp.de>
laeubi
force-pushed
the
add-socket-redirect-option
branch
from
7586df6 to
d45ade2
Compare
marcphilipp
requested changes
Oct 28, 2025
documentation/src/docs/asciidoc/release-notes/release-notes-6.1.0-M1.adoc
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/user-guide/advanced-topics/junit-platform-reporting.adoc
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListener.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java
Show resolved
Hide resolved
...c/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java
Outdated
Show resolved
Hide resolved
…1.0-M1.adoc Co-authored-by: Marc Philipp <mail@marcphilipp.de>
…it-platform-reporting.adoc Co-authored-by: Marc Philipp <mail@marcphilipp.de>
…rting/open/xml/OpenTestReportGeneratingListener.java Co-authored-by: Marc Philipp <mail@marcphilipp.de>
…/xml/OpenTestReportGeneratingListenerTests.java Co-authored-by: Marc Philipp <mail@marcphilipp.de>
added 2 commits
October 28, 2025 13:42
marcphilipp
approved these changes
Oct 28, 2025
|
Thanks, @laeubi! 👍 |
Thanks for the review an merge! as this and the OSGi thing is quite interesting for me may I ask if any 6.0.1 release is planned for JUnit or will 6.1.0 be the next (whenever it will happen). |
|
We will release 6.0.1 toward the end of the week but this change will not be included since it's not a bug fix but a new feature. We will probably release 6.1.0-M1 in the coming weeks, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adoption of a new feature in the open-test-reporting library here:
This is now an adaption for junit reporter so when socket property is set, connect to
localhost:<port>and write XML to socket.This allows e.g. to have an IDE connector or other tool that observe and visualize the test run in an external JUnit run. eg through the CLI.
I hereby agree to the terms of the JUnit Contributor License Agreement.
I have generated the content using copilot here, squashed the commits reviewed it and found it looks fine.
Definition of Done
@APIannotations