Stop reporting discovery issues for synthetic methods #5103
+75
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: Jupiter
component: Kotlin
theme: discovery
type: bug
labels
marcphilipp
force-pushed
the
marc/5102-suspendImpl-synthetic-method-fix
branch
2 times, most recently
from
56da3b8 to
682591f
Compare
Prior to this commit, _all_ methods of a potential test class were checked for being test methods, including synthetic ones. However, when resolving a test class only non-synthetic methods were taken into account. Since the Kotlin compiler generates a synthetic, static method suffixed with `$suspendImpl` for every open (i.e. non-final) method and copies its annotations, such methods were included in the check. In addition to filtering out synthetic methods from being checked, `KotlinReflectionUtils` no longer recognizes them as suspend functions. Fixes #5102.
marcphilipp
force-pushed
the
marc/5102-suspendImpl-synthetic-method-fix
branch
from
682591f to
a058571
Compare
sbrannen
approved these changes
Oct 28, 2025
marcphilipp
added a commit
that referenced
this pull request
Oct 30, 2025
Prior to this commit, _all_ methods of a potential test class were checked for being test methods, including synthetic ones. However, when resolving a test class only non-synthetic methods were taken into account. Since the Kotlin compiler generates a synthetic, static method suffixed with `$suspendImpl` for every open (i.e. non-final) method and copies its annotations, such methods were included in the check. In addition to filtering out synthetic methods from being checked, `KotlinReflectionUtils` no longer recognizes them as suspend functions. Fixes #5102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, all methods of a potential test class were
checked for being test methods, including synthetic ones. However, when
resolving a test class only non-synthetic methods were taken into
account.
Since the Kotlin compiler generates a synthetic, static method suffixed
with
$suspendImplfor every open (i.e. non-final) method and copiesits annotations, such methods were included in the check.
In addition to filtering out synthetic methods from being checked,
KotlinReflectionUtilsno longer recognizes them as suspend functions.Fixes #5102.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations