Skip to content

Remove workaround for bug fixed in JDK 9 and later #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
+1 −6
Merged

Remove workaround for bug fixed in JDK 9 and later #5112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ...atform-commons/src/main/java/org/junit/platform/commons/util/DefaultClasspathScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,7 @@ private String determineSimpleResourceName(Path resourceFile) {
private String determineSubpackageName(Path baseDir, Path file) {
Path relativePath = baseDir.relativize(file.getParent());
String pathSeparator = baseDir.getFileSystem().getSeparator();
String subpackageName = relativePath.toString().replace(pathSeparator, PACKAGE_SEPARATOR_STRING);
if (subpackageName.endsWith(pathSeparator)) {
// TODO: Remove workaround for JDK bug: https://bugs.openjdk.org/browse/JDK-8153248
subpackageName = subpackageName.substring(0, subpackageName.length() - pathSeparator.length());
}
return subpackageName;
return relativePath.toString().replace(pathSeparator, PACKAGE_SEPARATOR_STRING);
}

private void handleInternalError(Path classFile, String fullyQualifiedClassName, InternalError ex) {
Expand Down
Loading