Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Nov 22, 2025

Please review this change to avoid mutating final fields, by either removing the final modifier from options-related field in the console configuration helper classes or, for the time being, enabling final field mutation in Maven-based integration tests.

Closes #5173


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@sormuras sormuras self-assigned this Nov 22, 2025
@sormuras sormuras marked this pull request as ready for review November 22, 2025 23:12
@sormuras sormuras requested a review from marcphilipp November 23, 2025 11:13
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Please also add an entry to the 6.0.2 release notes.

@sormuras sormuras requested a review from marcphilipp November 23, 2025 16:49
@sormuras sormuras merged commit 0d1d359 into main Nov 23, 2025
17 checks passed
@sormuras sormuras deleted the issues/5173-final-means-final branch November 23, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Final field has been mutated reflectively warnings with JDK 26

3 participants