Attempt 2: Setting up for resolving issue 64, Theories honoring generic t #256
Conversation
…ic type parameters. This commit comprises only those changes required in the core of JUnit -- basically adding a validator that the Theories runner can call to reject theories with generic type variables (that are hard to resolve), and deprecating FrameworkMethod#producesType, which only the Theories runner uses, and which will be supplanted by an equivalent method on ParameterSignature. Other required changes will be added to the Theories experiment once it migrates over to junit.contrib.
…ucesType. Adding acknowledgements entry for pholser. Starting 4.9.1 release notes.
doc/ReleaseNotes4.9.1.txt
Outdated
|
Excellent. Just the one fix (version number in release notes), and we're finally ready to go. |
|
There we are. Thanks for your patience! |
Disable theories with generic type parameters in core Theories runner.
|
Au contraire, thank you! |
|
I was running a little coverage analysis of all of JUnit, and it turns out the class The reason for that is that the test class provided in the pull request, The most logical solution seems adding it to the Doing that shows that the new tests fail. The reason for this is that the method Could it be that some code was missing in the pull request? |
|
Hmm. @pholser, any thoughts? |
|
Happy to have a look. |
|
#572 should rectify the no-generic-parms validator missing execution/test. |
3 participants
Attempt 2: Setting up for resolving issue 64, Theories honoring generic type parameters. This commit comprises only those changes required in the core of JUnit -- basically adding a validator that the Theories runner can call to reject theories with generic type variables (that are hard to resolve), and deprecating FrameworkMethod#producesType, which only the Theories runner uses, and which will be supplanted by an equivalent method on ParameterSignature. Other required changes will be added to the Theories experiment once it migrates over to junit.contrib.