-
Notifications
You must be signed in to change notification settings - Fork 351
Document metric classes #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
281c153 to
91471c9
Compare
|
Long live Doxygen! |
|
Or clang-doc (https://clang.llvm.org/extra/clang-doc.html) - at one point in time. |
e9d9243 to
eaaf7d9
Compare
eaaf7d9 to
1f60dc4
Compare
|
please rebase to fix TravisCI |
1f60dc4 to
e7bb848
Compare
|
I rebased it. |
core/include/prometheus/histogram.h
Outdated
| /// chosen for which the given amount falls into the half-open interval [b_n, | ||
| /// b_n+1). The counter of the observed bucket is incremented. Also the total | ||
| /// sum of all observations is incremented. | ||
| void Observe(double); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason behind removing the argument names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the style currently used in many places of the library in the header file. Personally I would add the argument names also in the header (it also eases documenting with doxygen). I reverted the changes made to the argument names.
e7bb848 to
70e50e2
Compare
|
Do you have an idea where we could publish the generated doxygen files easily? I played around with "Read The Docs" here and Breathe / Sphinx, but it does not look promising. Uploading to github pages might also be an option, but maybe you know something easier to set up? |
|
Could you please rebase? |
70e50e2 to
439bd18
Compare
|
I rebased it. |
|
Regarding documentation I have no better idea. I think github pages is the most straightforward way. Travis simply generates the html and uploads it to a special branch. There are some examples: https://gist.github.com/francesco-romano/351a6ae457860c14ee7e907f2b0fc1a5 We need to pimp it a little bit further:
So I would still give it a try. |
c4d8190 to
8fcf5b0
Compare
|
I think the easiest way to get the documentation is GitHub pages. We could simply create a new repository and let travis push to it: https://github.com/jerryct/doc_test The doxygen config is this: |
No description provided.