Skip to content

Conversation

@jerryct
Copy link
Contributor

@jerryct jerryct commented Oct 16, 2018

No description provided.

@bdangit
Copy link

bdangit commented Oct 16, 2018

Long live Doxygen!

@jerryct
Copy link
Contributor Author

jerryct commented Oct 16, 2018

Or clang-doc (https://clang.llvm.org/extra/clang-doc.html) - at one point in time.

@jerryct jerryct force-pushed the add_documentation branch 2 times, most recently from e9d9243 to eaaf7d9 Compare October 16, 2018 17:07
@jerryct jerryct changed the title Document counter and gauge Document metric classes Oct 16, 2018
@gjasny
Copy link
Collaborator

gjasny commented Oct 16, 2018

please rebase to fix TravisCI

@jerryct
Copy link
Contributor Author

jerryct commented Oct 17, 2018

I rebased it.

/// chosen for which the given amount falls into the half-open interval [b_n,
/// b_n+1). The counter of the observed bucket is incremented. Also the total
/// sum of all observations is incremented.
void Observe(double);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason behind removing the argument names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the style currently used in many places of the library in the header file. Personally I would add the argument names also in the header (it also eases documenting with doxygen). I reverted the changes made to the argument names.

@gjasny
Copy link
Collaborator

gjasny commented Oct 25, 2018

Do you have an idea where we could publish the generated doxygen files easily? I played around with "Read The Docs" here and Breathe / Sphinx, but it does not look promising. Uploading to github pages might also be an option, but maybe you know something easier to set up?

@gjasny
Copy link
Collaborator

gjasny commented Oct 25, 2018

Could you please rebase?

@jerryct
Copy link
Contributor Author

jerryct commented Oct 26, 2018

I rebased it.

@jerryct
Copy link
Contributor Author

jerryct commented Oct 26, 2018

Regarding documentation I have no better idea. I think github pages is the most straightforward way. Travis simply generates the html and uploads it to a special branch. There are some examples:

https://gist.github.com/francesco-romano/351a6ae457860c14ee7e907f2b0fc1a5

We need to pimp it a little bit further:

  • don't generate private/protected members
  • exclude namespace detail with a doxygen annotation
  • remove these file, dir and namespace stuff

So I would still give it a try.

@jerryct jerryct force-pushed the add_documentation branch 3 times, most recently from c4d8190 to 8fcf5b0 Compare October 26, 2018 15:40
@jerryct
Copy link
Contributor Author

jerryct commented Oct 26, 2018

I think the easiest way to get the documentation is GitHub pages. We could simply create a new repository and let travis push to it:

https://github.com/jerryct/doc_test
https://jerryct.github.io/doc_test/index.html
https://jerryct.github.io/doc_test/annotated.html

The doxygen config is this:
2c476f1

@gjasny gjasny merged commit 8cb7bde into jupp0r:master Oct 27, 2018
@jerryct jerryct mentioned this pull request Oct 27, 2018
@jerryct jerryct deleted the add_documentation branch October 28, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants