Generate gh pages #194
Merged
Generate gh pages #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jerryct
reviewed
Oct 27, 2018
.travis.yml
Outdated
| - make DESTDIR=`pwd`/deploy install | ||
| - popd | ||
|
|
||
| - cd "${TRAVIS_BUILD_DIR}/doc" |
Contributor
There was a problem hiding this comment.
Better use pushd and call popd after line 53. That makes it extensible for the future without touching these 3 lines of code.
jerryct
reviewed
Oct 28, 2018
Owner
|
Sorry for responding so late, got back from vacation. I'll take care of this later this week. Thanks @gjasny |
Closed
Owner
|
Should be unblocked by #250 |
Owner
|
Please rebase + merge |
gjasny
force-pushed
the
generate-gh-pages
branch
from
b5492a3 to
bc09858
Compare
gjasny
force-pushed
the
generate-gh-pages
branch
from
bc09858 to
cf0cd75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jupp0r Could you please create a token named
GITHUB_TOKENas described here and add it to the globalsecureelements list in.travis.yml?That should update doxygen on https://jupp0r.github.io/prometheus-cpp/
Example output available here: https://gjasny.github.io/prometheus-cpp/